fix(tooltip): toggle aria-hidden so iphone voiceover works correctly #14313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
requested review from
andreancardona
and removed request for
tay1orjones
andreancardona
approved these changes
Jul 26, 2023
|
😎 |
andreancardona
added
status: one more review 👀
and removed
status: ready for review 👀
labels
guidari
approved these changes
Jul 27, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
via the queue into
carbon-design-system:main
with commit Jul 28, 2023
75bdc60
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13939
Set aria-hidden to false when tooltip is open so that it is read on iphone
Testing / Reviewing
Make sure nothing has changed with tooltip, and if you want to test on iphone