Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slider): add range slider #14297

Merged
merged 79 commits into from
Oct 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
79 commits
Select commit Hold shift + click to select a range
1b055c9
feat(slider): add prop for two handles to range slider
m4olivei Jul 20, 2023
7a0677f
feat(slider): first pass adding second input for two handles
m4olivei Jul 20, 2023
11ebee1
feat(slider): fix spacing to accomodate two handles
m4olivei Jul 20, 2023
dbd9851
feat(slider): use initial props to set state and initial render
m4olivei Jul 20, 2023
ee9036e
feat(slider): implement drag handle logic for two handles
m4olivei Jul 20, 2023
2b1457e
feat(slider): collision detection for the drag handles
m4olivei Jul 24, 2023
b663610
feat(slider): remove unused expression
m4olivei Jul 24, 2023
d4a48e1
feat(slider): collision detection for keyboard events
m4olivei Jul 24, 2023
4d9e0a3
feat(slider): tighten up some type checks
m4olivei Jul 24, 2023
19039cb
feat(slider): handle the empty case for the text inputs
m4olivei Jul 24, 2023
fc7a33d
feat(slider): adjust aria attributes for thumbs and inputs
m4olivei Jul 24, 2023
c95c165
feat(slider): code consistency and some docs
m4olivei Jul 25, 2023
6b635c7
feat(slider): expand the onChange callback for valueLower and valueUpper
m4olivei Jul 25, 2023
ccba687
feat(slider): expand the onBlur callback for valueLower and valueUpper
m4olivei Jul 25, 2023
4e22da6
feat(slider): expand the onInputKeyUp and onRelease callbacks
m4olivei Jul 25, 2023
f3746ec
feat(slider): tidy up slider stories a bit
m4olivei Jul 25, 2023
8e38e5c
feat(slider): fix the aria labeling for range slider
m4olivei Jul 25, 2023
f6d7126
feat(slider): fix clearing the error state incorrectly
m4olivei Jul 25, 2023
f6b684c
feat(slider): fix error state for twoHandles
m4olivei Jul 25, 2023
a050da4
feat(slider): initial pass at range slider styles
m4olivei Jul 26, 2023
36f18a4
feat(slider): fix React errors in console
m4olivei Jul 26, 2023
ee19c9b
feat(slider): correct for same value
m4olivei Jul 26, 2023
223ca9f
feat(slider): initial styles and support for skeleton
m4olivei Jul 26, 2023
512ef46
feat(slider): fix margin around track
m4olivei Jul 31, 2023
b8cc808
feat(slider): touch up read only state
m4olivei Jul 31, 2023
b52d12c
feat(slider): touch up skeleton component for two handles
m4olivei Jul 31, 2023
57d24d9
chore(slider): update jest snapshot
m4olivei Aug 1, 2023
9c79b2f
fix(slider): fix bug with handle touch drag
m4olivei Aug 1, 2023
f13e6f5
fix(slider): fix to allow freeform input
m4olivei Aug 2, 2023
f2a3aa8
fix(slider): tweaks to onChange / onBlur combination
m4olivei Aug 2, 2023
14705dd
fix(slider): undefined var
m4olivei Aug 2, 2023
3b3a7a0
fix(slider): use token when appropriate
m4olivei Aug 2, 2023
d4aed3a
fix(slider): adjust distanceToHandle calculation
m4olivei Aug 3, 2023
c7bcfaa
fix(slider): fix click focus plus keyboard nav
m4olivei Aug 3, 2023
92dd996
fix(slider): use focus token for filled track
m4olivei Aug 3, 2023
b26c8c6
fix(slider): allow invalid on input, fix on blur
m4olivei Aug 3, 2023
4ff1b9a
fix(slider): fix regressions on default slider
m4olivei Aug 3, 2023
d3b4f11
feat(slider): adjust test to consider auto-correct
m4olivei Aug 3, 2023
c5a951a
Merge branch 'main' into feat/range-slider
m4olivei Aug 3, 2023
cdfecc4
test(slider): start writing tests for two handle slider
m4olivei Aug 3, 2023
a6b4a2f
Merge branch 'main' into feat/range-slider
m4olivei Aug 3, 2023
f9f4da9
Merge branch 'main' into feat/range-slider
m4olivei Aug 21, 2023
626bbd5
feat(slider): consolidate lower props to utilize existing props
m4olivei Aug 22, 2023
05f842f
fix(slider): sync props to state when appropriate
m4olivei Aug 22, 2023
09bcfd7
Merge branch 'main' into feat/range-slider
m4olivei Aug 22, 2023
871fe5d
fix(slider): update new props to be prefixed with unstable_
m4olivei Aug 22, 2023
31a3222
feat(slider): add auto-update notification
m4olivei Aug 23, 2023
d683222
Merge branch 'main' into feat/range-slider
m4olivei Aug 23, 2023
022e881
fix(slider): set back the storybook invalid message
m4olivei Aug 24, 2023
20e5b9d
fix(slider): avoid using deprecated KeyboardEvent.which
m4olivei Aug 24, 2023
999a3af
fix(slider): avoid setting string value in state
m4olivei Aug 24, 2023
1a43f3f
test(slider): add tests parity for two handle slider
m4olivei Aug 24, 2023
8a1b9fe
Merge branch 'main' into feat/range-slider
m4olivei Aug 24, 2023
0ee182e
Merge branch 'main' into feat/range-slider
m4olivei Sep 1, 2023
feaa3e7
Merge branch 'main' into feat/range-slider
m4olivei Sep 8, 2023
c26efe2
fix(slider): adjust track click heuristic
m4olivei Sep 8, 2023
74fcdcf
Merge branch 'main' into feat/range-slider
m4olivei Sep 19, 2023
e9cad6f
fix(slider): adjustments for rtl writing mode
m4olivei Sep 19, 2023
e1d137b
feat(slider): provide translation function prop
m4olivei Sep 19, 2023
5a5484d
Merge branch 'main' into feat/range-slider
m4olivei Sep 19, 2023
65b1103
chore(slider): make the linter happy
m4olivei Sep 19, 2023
a30c9ae
fix(slider): fix Typescript issues
m4olivei Sep 19, 2023
584ba9a
test(slider): add e2e tests for two handle slider
m4olivei Sep 19, 2023
dfd05de
test(slider): fix test for css logical properties
m4olivei Sep 19, 2023
b23456e
docs(slider): include note re unstable_valueUpper prop
m4olivei Sep 20, 2023
40a6b04
Merge branch 'main' into feat/range-slider
m4olivei Oct 2, 2023
1a1dd3b
fix(slider): show warning when we auto-correct the slider
m4olivei Oct 2, 2023
743c3c7
fix(slider): use svg icons for two handle slider
m4olivei Oct 3, 2023
5d34ffd
fix(slider): use token for foreground color of range handles
m4olivei Oct 3, 2023
d8e1bcf
fix(slider): rtl fixes for slider handles
m4olivei Oct 3, 2023
214dda1
Merge branch 'main' into feat/range-slider
m4olivei Oct 3, 2023
8ff8040
fix(slider): hide the track below the handle
m4olivei Oct 4, 2023
5205aee
Merge branch 'main' into feat/range-slider
m4olivei Oct 4, 2023
b67f1d9
fix(slider): adjust token from focus to interactive
m4olivei Oct 6, 2023
a6521b5
fix(slider): adjust label case
m4olivei Oct 6, 2023
c1e5089
Merge branch 'main' into feat/range-slider
m4olivei Oct 6, 2023
a334a95
Merge branch 'main' into feat/range-slider
m4olivei Oct 16, 2023
8af20a3
Merge branch 'main' into feat/range-slider
tay1orjones Oct 17, 2023
d95b07c
Merge branch 'main' into feat/range-slider
m4olivei Oct 18, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions e2e/components/Slider/Slider-test.avt.e2e.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,17 @@ test.describe('Slider @avt', () => {
);
});

test('accessibility-checker two handle slider', async ({ page }) => {
await visitStory(page, {
component: 'Slider',
id: 'components-slider--two-handle-slider',
globals: {
theme: 'white',
},
});
await expect(page).toHaveNoACViolations('Slider-two-handle-slider');
});

test('accessibility-checker skeleton', async ({ page }) => {
await visitStory(page, {
component: 'Slider',
Expand All @@ -61,6 +72,17 @@ test.describe('Slider @avt', () => {
await expect(page).toHaveNoACViolations('Slider-skeleton');
});

test('accessibility-checker two handle skeleton', async ({ page }) => {
await visitStory(page, {
component: 'Slider',
id: 'components-slider--two-handle-skeleton',
globals: {
theme: 'white',
},
});
await expect(page).toHaveNoACViolations('Slider-two-handle-skeleton');
});

test('accessibility-checker slider with layer', async ({ page }) => {
await visitStory(page, {
component: 'Slider',
Expand Down
8 changes: 8 additions & 0 deletions e2e/components/Slider/Slider-test.e2e.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@ test.describe('Slider', () => {
theme,
});
});

test('two handle slider @vrt', async ({ page }) => {
await snapshotStory(page, {
component: 'Slider',
id: 'components-slider--two-handle-slider',
theme,
});
});
});
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -7288,6 +7288,9 @@ Map {
"hideLabel": Object {
"type": "bool",
},
"twoHandles": Object {
"type": "bool",
},
},
},
"Stack" => Object {
Expand Down
Loading
Loading