Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVT]: Added avt tests for OverflowMenu #14250

Merged
merged 8 commits into from
Jul 27, 2023

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Jul 19, 2023

Closes #14212

Added avt tests to variants in the stories and keyboard nav testing

Testing / Reviewing

  • CI should pass
  • Ensure the tests written make sense to the user keyboard navigation

@guidari guidari requested a review from a team as a code owner July 19, 2023 17:36
@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 13da281
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64c2c4b4c9900f000953341f
😎 Deploy Preview https://deploy-preview-14250--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 13da281
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64c2c4b4025de70008758847
😎 Deploy Preview https://deploy-preview-14250--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion

e2e/components/OverflowMenu/OverflowMenu-test.avt.e2e.js Outdated Show resolved Hide resolved
@andreancardona andreancardona self-requested a review July 20, 2023 12:52
@guidari guidari requested a review from tay1orjones July 24, 2023 14:40
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@tay1orjones tay1orjones added this pull request to the merge queue Jul 27, 2023
Merged via the queue into carbon-design-system:main with commit 99470fb Jul 27, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AVT coverage for OverflowMenu states: Keyboard nav
4 participants