chore: updated next and react version in example #14219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
requested changes
Jul 17, 2023
Hey @tay1orjones I didn't find a way to fix that on NextJS. The example works outside of the monorepo, but not inside it, for some reason. But I could fixed it by migrating the example to use Vite instead of NextJS. Check this Draft PR My suggestion is to use that migration as an example to this issue, about how we can approach this transition. |
tay1orjones
approved these changes
Jul 27, 2023
alisonjoseph
approved these changes
Jul 28, 2023
alisonjoseph
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
1 task
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
via the queue into
carbon-design-system:main
with commit Aug 1, 2023
909f48d
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After working on this PR it was found a few errors when running an example using NextJS.
To fix that it was updated the next and react versions in the
package.jsonfor each example.Changed
package.jsonexamplesTesting / Reviewing
Pull the branch locally and run the examples