test(menu): add vrt and avt #13207
Merged
test(menu): add vrt and avt #13207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
tay1orjones
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Is there a way to create stories that are not indexed by storybook but can be picked up by percy?
@janhassel No, not yet - #12971. For now we're only snapshotting existing stories showing a single state. Using just the playground story for now is great 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #11770
Adds VRT and AVT for
MenucomponentChangelog
New
Menu-test.e2e.jsto enable VRT and AVTChanged
falsetoMenuItemSelectableselectedstate to avoidaria-checkednot being populated when neitherdefaultSelectednorselectedis passed@tay1orjones Is there a way to create stories that are not indexed by storybook but can be picked up by percy? That way we could have separate tests for each of the subcomponents (
MenuItem*). Or would you say covering the Playground story is sufficient?