Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: ariaLabel removal or deprecation log changes #17584

Open
1 task done
ev-codes opened this issue Sep 26, 2024 · 1 comment
Open
1 task done

[Feature Request]: ariaLabel removal or deprecation log changes #17584

ev-codes opened this issue Sep 26, 2024 · 1 comment

Comments

@ev-codes
Copy link

ev-codes commented Sep 26, 2024

The problem

getSelectionProps() (part of @carbon/react) returns ariaLabel as one of the properties.

However, <TableSelectAll> logs a deprecation warning to console.warn when ariaLabel is passed into it. Unnecessary logs make it more difficult to find more important issues and slow down CI workflows.

The solution

Either:

  • getSelectionProps() no longer returns ariaLabel
  • <TableSelectAll> should not log a deprecation warning when receiving ariaLabel

Examples

Code:

<TableSelectAll {...getSelectionProps()} aria-label="entity table select all" />

Logs from test:

console.warn
    Warning: This prop syntax has been deprecated. Please use the new `aria-label`.

Application/PAL

No response

Business priority

None

Available extra resources

No response

Code of Conduct

Copy link
Contributor

Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.

If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Triage
Development

No branches or pull requests

1 participant