Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Data table interactive cell has inconsistent guidance around disabled states. #17307

Open
2 tasks done
alina-jacob opened this issue Aug 30, 2024 · 1 comment
Open
2 tasks done

Comments

@alina-jacob
Copy link
Member

alina-jacob commented Aug 30, 2024

Description

Code functionality
As per code, if a row is selectable and the feature needs to be disabled, only the button is disabled, the cell text is readable.
[Note: The code attached here is from C4IP because Carbon data table doesn't have a "disable" prop yet.]

image


Usage guidance
In our docs, when we show disabled state we show both the button and the text disabled (entire cell is disabled)
image


Thoughts

  • Both use-cases can be valid in their own ways, however disabling cell text makes it completely inaccessible from a color contrast perspective.
  • If the selectable checkbox is disabled and cell text has read-only token colours then it solves both purposes, inability to interact with the checkbox but still readable and accessible.

Expectations

  • Add the disabled state for row / cell in the data table component.
  • Update docs to reflect this (just the button/s should be disabled, not the text) (if a disabled styling is required for text consider using read-only token color)

Code of Conduct

Copy link
Contributor

Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.

If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🪆 Needs Refined
Status: Triage
Development

No branches or pull requests

1 participant