Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook footer display issue on mobile #16053

Open
2 tasks
alisonjoseph opened this issue Mar 25, 2024 · 6 comments
Open
2 tasks

Storybook footer display issue on mobile #16053

alisonjoseph opened this issue Mar 25, 2024 · 6 comments
Assignees
Labels
Milestone

Comments

@alisonjoseph
Copy link
Member

alisonjoseph commented Mar 25, 2024

STATUS: Ready for dev next sprint (97)

Acceptance criteria

The height of the footer on mobile screens makes the storybook almost unusable. We are currently using the dot com footer component.

Design

  • Need a recommendation from design, and then will need to apply the update to all public storybooks. (charts, v7 storybook, ibm products, dot com, webcomponents)

image

Playback

  • Playback to team to decide on which design spec to build.
@tay1orjones
Copy link
Member

Could we do something like cloud where we move these links to somewhere else in the UI? They put the privacy link in a uishell dropdown.

Image

When you click it, it opens a modal with the cookie prefs

Image

This way they avoid any footer on the page. Storybook is a bit different than a typical ibm.com page because it's essentially a single page app at 100% x 100% with no ability to scroll the footer out of the way

@sstrubberg sstrubberg added the severity: 2 https://ibm.biz/carbon-severity label Oct 16, 2024
@sstrubberg sstrubberg added this to the 2024 Q4 milestone Oct 16, 2024
@sstrubberg sstrubberg moved this from 🪆 Needs Refined to ⏱ Backlog in Design System Oct 16, 2024
@tay1orjones
Copy link
Member

Two options discussed today

@aagonzales
Copy link
Member

aagonzales commented Oct 25, 2024

@alisonjoseph @tay1orjones Do the links need to be persistent? If not, could we just have the footer on the Welcome page and then not have it show up on other pages?

If that's not possible, we should just add the links to the bottom of the left nav. That seems like more of a natural spot than in the header bar.

Image

@alisonjoseph
Copy link
Member Author

alisonjoseph commented Oct 28, 2024

@aagonzales They need to be on all pages, I agree bottom of the left nav probably makes the most sense.

I believe its just the Privacy and cookie preferences links that we need, not the entire list of links in the footer.

@aagonzales
Copy link
Member

If we can add icons to the right side of the header than could work too, I just don't think it fits in with the content on the left side of the header. Image

Or the bottom of the left nav if you can get external links to work there
Image

@aagonzales aagonzales moved this from ⏱ Backlog to 🏗 In Progress in Design System Nov 7, 2024
@aagonzales
Copy link
Member

I think this issue is ready to go to the dev next sprint. We should try to see which of those two versions is possible in Storybook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🏗 In Progress
Development

No branches or pull requests

4 participants