Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIShell HeaderMenu puts "# in URL when drop-down is clicked #14708

Closed
rafael-nogueras opened this issue Mar 16, 2022 · 3 comments
Closed

UIShell HeaderMenu puts "# in URL when drop-down is clicked #14708

rafael-nogueras opened this issue Mar 16, 2022 · 3 comments
Assignees
@guidari
Labels
adopter: product Work-stream that directly helps a Product team. component: ui-shell package: @carbon/react @carbon/react role: dev 🤖 severity: 2 https://ibm.biz/carbon-severity status: needs triage 🕵️‍♀️ type: bug 🐛 version: 11 Issues pertaining to Carbon v11

Comments

@rafael-nogueras
Copy link

rafael-nogueras commented Mar 16, 2022 •
edited
Loading

When the user clicks on the UIShell's drop-down component, before selecting anything, the URL gets set to #. This is because the HeaderMenu component injects an <a> element with href="#":

image

It seems to be that if the click handler invoked event.stopPropagation(), then the URL would not be changed and it would work as desired.

The issue that originally describes this issue is this one.
@tay1orjones
Copy link
Member

It looks like a fix is coming in #10967

@sstrubberg sstrubberg added type: bug 🐛 adopter: product Work-stream that directly helps a Product team. version: 11 Issues pertaining to Carbon v11 package: @carbon/react @carbon/react severity: 2 https://ibm.biz/carbon-severity labels Nov 30, 2022
@sstrubberg sstrubberg modified the milestone: 2023 Q1 Dec 5, 2022
@alisonjoseph alisonjoseph transferred this issue from carbon-design-system/carbon-website Sep 25, 2023
@guidari
Copy link
Contributor

guidari commented Jan 9, 2024

Hey @rafael-nogueras
I was checking this issue and looks like have been fixed. I couldn't reproduce in the storybook. The "#" is not being placed in the URL.

If the error persists, could you reproduce it on Stackblitz, please?

@guidari guidari self-assigned this Jan 9, 2024
@guidari
Copy link
Contributor

guidari commented Jan 10, 2024

We will close this, but if you find this issue is not actually resolved, please open a new issue and include a link back to this issue.

@guidari guidari closed this as completed Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guidari guidari

Labels
adopter: product Work-stream that directly helps a Product team. component: ui-shell package: @carbon/react @carbon/react role: dev 🤖 severity: 2 https://ibm.biz/carbon-severity status: needs triage 🕵️‍♀️ type: bug 🐛 version: 11 Issues pertaining to Carbon v11
Projects
Design System
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tay1orjones @sstrubberg @rafael-nogueras @laurenmrice @guidari