Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContextMenu: Implementation #13514

Closed
4 of 5 tasks
Tracked by #11770
sstrubberg opened this issue Apr 12, 2023 · 0 comments · Fixed by #13678
Closed
4 of 5 tasks
Tracked by #11770

ContextMenu: Implementation #13514

sstrubberg opened this issue Apr 12, 2023 · 0 comments · Fixed by #13678
Assignees
@janhassel
Labels
adopter: PAL Work-stream that directly helps a Pattern & Asset Library. component: context-menu package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡
Milestone
2023 Q2

Comments

@sstrubberg
Copy link
Member

sstrubberg commented Apr 12, 2023 •
edited by tay1orjones
Loading

Acceptance Criteria

  • Go through the newly defined steps from Further define acceptance criteria for moving components to stable #11688 to move ContextMenu from unstable to stable
  • Needs storybook updates, remove generator config, replace with usage examples, figure out left nav hierarchy/naming
  • Namespaces within the Menu exports need to be removed
  • useEffect within the Menu needs to be revisited - ignoring deps, ensure edge cases are covered
  • Revisit useContextMenu hook to instead use React context. No longer detect the children directly, but instead communicate through this context
@sstrubberg sstrubberg mentioned this issue Apr 12, 2023
Closed
@sstrubberg sstrubberg added role: dev 🤖 component: context-menu package: @carbon/react @carbon/react adopter: PAL Work-stream that directly helps a Pattern & Asset Library. proposal: accepted This request has gone through triaging and we are accepting PR's against it. type: enhancement 💡 and removed status: needs triage 🕵️‍♀️ labels Apr 12, 2023
@sstrubberg sstrubberg added this to the 2023 Q2 milestone Apr 12, 2023
@janhassel janhassel mentioned this issue Apr 27, 2023
Merged
22 tasks
@kodiakhq kodiakhq bot closed this as completed in #13678 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janhassel janhassel

Labels
adopter: PAL Work-stream that directly helps a Pattern & Asset Library. component: context-menu package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡
Projects
Community Workgroups
Status: ✅ Done
Milestone
2023 Q2
Development

Successfully merging a pull request may close this issue.

chore(menu): move to stable janhassel/carbon
2 participants
@sstrubberg @janhassel