Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: small Loading spinner wobbles when line height is not 1rem #13121

Closed
2 tasks done
TheophileMot opened this issue Feb 8, 2023 · 1 comment · Fixed by #15085
Closed
2 tasks done

[Bug]: small Loading spinner wobbles when line height is not 1rem #13121

TheophileMot opened this issue Feb 8, 2023 · 1 comment · Fixed by #15085

Comments

@TheophileMot
Copy link

Package

@carbon/react

Browser

Chrome

Package version

v1.21.0

React version

18.2.0

Description

The small Loading spinner might not be centred, depending on the computed line-height property. This makes it wobble or spin wildly out of control.

I think this should fix it:

.cds--loading--small {
  width: 1rem;
  height: 1rem;
  line-height: 1rem;   // <--- add
}

Reproduction/example

https://stackblitz.com/edit/github-9cxysl?file=src%2FApp.jsx

Steps to reproduce

Stare intently at the Loading spinner.

Suggested Severity

Severity 4 = Unrelated to a user task, has a workaround or does not need a workaround.

Application/PAL

No response

Code of Conduct

@andreancardona
Copy link
Contributor

@TheophileMot thanks for catching this - adding it to our backlog :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants