Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContextMenu: Bring to stable ☂️ #11770

Closed
2 tasks done
Tracked by #11688
tay1orjones opened this issue Jul 8, 2022 · 5 comments
Closed
2 tasks done
Tracked by #11688

ContextMenu: Bring to stable ☂️ #11770

tay1orjones opened this issue Jul 8, 2022 · 5 comments
Assignees
Labels
adopter: PAL Work-stream that directly helps a Pattern & Asset Library. component: context-menu needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. planning: umbrella Umbrella issues, surfaced in Projects views proposal: accepted This request has gone through triaging and we are accepting PR's against it. type: enhancement 💡
Milestone

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Jul 8, 2022

Originally proposed in #6830, it's been over a year since the original submission and likely this is ready to move from unstable to stable

Tasks

  1. adopter: PAL kit: figma role: design ✏️ type: enhancement 💡
    thyhmdo
  2. adopter: PAL component: context-menu package: @carbon/react proposal: accepted role: dev 🤖 type: enhancement 💡
    janhassel
@tay1orjones
Copy link
Member Author

@janhassel thanks for meeting today about this one! Capturing some notes below - feel free to add or reclarify any pieces:

Needs storybook updates, remove generator config, replace with usage examples, figure out left nav hierarchy/naming

  • Move OverflowV2 out from under "Menu" to be it's own root level item in the storybook left nav
  • Add some basic stories for Menu showing off the Menu components in isolation
    • Add these basic stories to the e2e tests so they're covered by Percy/Visual regression tests
  • Rename "ContextMenu" story folder to "useContextMenu"
  • Add a .mdx docs page for Menu and include there a blurb about useContextMenu and how it can be a useful augmentation w/ Menu components. Provide a link to the useContextMenu default story.

@sstrubberg sstrubberg added adopter: PAL Work-stream that directly helps a Pattern & Asset Library. adopter: DSAG type: enhancement 💡 proposal: accepted This request has gone through triaging and we are accepting PR's against it. labels Dec 20, 2022
@tay1orjones tay1orjones added the needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. label Mar 15, 2023
@janhassel
Copy link
Member

@tay1orjones With the recent changes, would you mind re-assessing this checklist and the completion status?
Irt the two points "Add to Figma kit" and "Finish website docs" I will need some assistance from a Carbon designer to tackle this.

@sstrubberg sstrubberg modified the milestones: 2023 Q1, 2023 Q2 Apr 5, 2023
@sstrubberg sstrubberg changed the title Bring ContextMenu to stable ContextMenu: Bring to stable ☂️ Apr 12, 2023
@sstrubberg sstrubberg added the planning: umbrella Umbrella issues, surfaced in Projects views label Apr 12, 2023
@sstrubberg
Copy link
Member

sstrubberg commented Apr 12, 2023

@janhassel I stubbed out the work. We'll have a designer on our team handle the website docs and figma kit. You'll just take care of the implementation :)

@sstrubberg
Copy link
Member

sstrubberg commented Apr 17, 2023

Need to talk to @tay1orjones and @laurenmrice about the naming of this in our next refinement meeting.

@tay1orjones tay1orjones modified the milestones: 2023 Q2, 2023 Q3 Jul 10, 2023
@sstrubberg
Copy link
Member

Documentation is being tracked in Menu and Friends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: PAL Work-stream that directly helps a Pattern & Asset Library. component: context-menu needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. planning: umbrella Umbrella issues, surfaced in Projects views proposal: accepted This request has gone through triaging and we are accepting PR's against it. type: enhancement 💡
Projects
Status: Done
Archived in project
Development

No branches or pull requests

4 participants