Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React] DataTable: row expansion animation isn't smooth #11354

Open
2 tasks done
freder opened this issue May 6, 2022 · 2 comments
Open
2 tasks done

[React] DataTable: row expansion animation isn't smooth #11354

freder opened this issue May 6, 2022 · 2 comments
Labels
component: data-table role: dev 🤖 severity: 4 https://ibm.biz/carbon-severity type: bug 🐛 version: 11 Issues pertaining to Carbon v11

Comments

@freder
Copy link

freder commented May 6, 2022

Package

@carbon/react

Browser

Chrome

Package version

1.2.0

React version

17.0.2

Description

https://react.carbondesignsystem.com/?path=/story/components-datatable-expansion--usage

click the row expansion button (v) to open and close the row. observe how the opening animation isn't smooth. -- seems to directly jump to the height of the contained content.

CodeSandbox example

https://react.carbondesignsystem.com/?path=/story/components-datatable-expansion--usage

Steps to reproduce

see description

Code of Conduct

@freder freder changed the title [Bug]: [React] DataTable: row expansion animation isn't smooth [React] DataTable: row expansion animation isn't smooth May 6, 2022
@tay1orjones tay1orjones added severity: 4 https://ibm.biz/carbon-severity impact: medium component: data-table version: 10 Issues pertaining to Carbon v10 version: 11 Issues pertaining to Carbon v11 and removed status: needs triage 🕵️‍♀️ labels May 16, 2022
@tay1orjones
Copy link
Member

It looks like this is due to the row height being animated open from zero to a calculated/auto value, which can't be interpolated for animation. I'm not sure how we could fix this, there might be a css solution but am not sure.

@joshblack
Copy link
Contributor

This may be what we're running into in terms of transition issues: https://css-tricks.com/using-css-transitions-auto-dimensions/ where the height is going from a 0 value to an auto value (potentially)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data-table role: dev 🤖 severity: 4 https://ibm.biz/carbon-severity type: bug 🐛 version: 11 Issues pertaining to Carbon v11
Projects
Status: ⏱ Backlog
Development

No branches or pull requests

4 participants