Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Modal, Menu buttons (Overflow menu), Treeview) Feature flag usage, code tab update #4287

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Kritvi-bhatia17
Copy link
Contributor

Closes #3993
Closes #4223
Closes #4226

Short description

This PR updates the component's Usage and Code tabs with the feature flag code changes for Modal, Menu buttons (Overflow menu), and Treeview, including feature flag information and images.

Note: Links pointing to the "Feature Flag tab" are currently non-functional as that page is not live yet.


Changelog

New

Usage:

  • Feature flag tag
  • Content (feature flag section)

Code:

  • Resource card feature flag tag
  • Content (feature flag section)

For ref: Figma file

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ❌ Failed (Inspect) Sep 27, 2024 8:40pm

@Kritvi-bhatia17 Kritvi-bhatia17 marked this pull request as ready for review September 24, 2024 14:29
@Kritvi-bhatia17 Kritvi-bhatia17 changed the title Adding feature flag to Modal, Menu buttons (Overflow menu), Treeview docs(Modal, Menu buttons (Overflow menu), Treeview) Feature flag usage, code tab update Sep 24, 2024
@carbon-design-system carbon-design-system deleted a comment from netlify bot Sep 24, 2024
Copy link
Member

@thyhmdo thyhmdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few suggestions.

src/pages/components/modal/code.mdx Show resolved Hide resolved
framework.

The `enable-v12-overflowmenu` flag improves accessibility by more closely
following the APG pattern for Menu and supports all the new Menu primitives.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making sure if this Menu, all Menu buttons, or the overflow menu?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Since it's only for the subcomponent of the Menu button (i.e., Overflow menu), I’ll check with @laurenmrice (once she's back from her vacation) to confirm if any updates are needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it clarifies here and subcomponents of Menu (or context menu)

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah right, I checked that. Lauren wrote that, I just want to double-check with her before making the change. Thanks for sharing that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants