-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(Modal, Menu buttons (Overflow menu), Treeview) Feature flag usage, code tab update #4287
base: main
Are you sure you want to change the base?
docs(Modal, Menu buttons (Overflow menu), Treeview) Feature flag usage, code tab update #4287
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few suggestions.
framework. | ||
|
||
The `enable-v12-overflowmenu` flag improves accessibility by more closely | ||
following the APG pattern for Menu and supports all the new Menu primitives. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just making sure if this Menu, all Menu buttons, or the overflow menu?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Since it's only for the subcomponent of the Menu button (i.e., Overflow menu), I’ll check with @laurenmrice (once she's back from her vacation) to confirm if any updates are needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it clarifies here and subcomponents of Menu (or context menu)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah right, I checked that. Lauren wrote that, I just want to double-check with her before making the change. Thanks for sharing that!
…atia17/carbon-website into FF_Modal,OverflowMenu,TreeView
Closes #3993
Closes #4223
Closes #4226
Short description
Changelog
New
Usage:
Code:
For ref: Figma file