Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs (notifications a11y): update to new template #4270

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

benjamin-kurien
Copy link
Contributor

Closes #4253

Accessibility document for notification, updated to follow the new template.

Changelog

New

  • Keyboard interactions for all notification types, with images.
  • Design recommendations for semantic styling
  • Development considerations

Changed

  • Updated to new template

Removed

  • Irrelevant sections from previous template was removed. Data was retained and moved to the relevant sections under the new template.

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 9:13pm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @benjamin-kurien, just adding a comment on the images. The tab stop curvature looked a little inconsistent (based on the perpendicular logic) so I have attempted an exploration here (but, this is in 3:2 aspect ratio and not the 16:9 as recommended in the crit-call)

So totally your call!
image
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this was a good catch, @alina-jacob. You are totally right. We normally want the line to start going straight up for just a little bit before it starts curving. This is why we need to make some components for these arrows. It's easy to miss those nuances. I didn't even notice it at first.
image

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me except that one image tweak @alina-jacob found. Once that is fixed its good from my perspective.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this was a good catch, @alina-jacob. You are totally right. We normally want the line to start going straight up for just a little bit before it starts curving. This is why we need to make some components for these arrows. It's easy to miss those nuances. I didn't even notice it at first.
image

@mbgower
Copy link
Contributor

mbgower commented Sep 23, 2024

@benjamin-kurien as I mentioned on a prior call, the accessibility content is normally built to complement information already provided in the Usage and Style tabs; however, when I look at the deployment preview, there is no occurrence of the word "Callout" on either of these pages. The only place it is covered is the a11y tab.
Is that just a result of those changes being in a separate PR? If so, please provide, as it is hard to review this material without knowing what the user has already been told about Callouts on other tabs.

@benjamin-kurien
Copy link
Contributor Author

@benjamin-kurien as I mentioned on a prior call, the accessibility content is normally built to complement information already provided in the Usage and Style tabs; however, when I look at the deployment preview, there is no occurrence of the word "Callout" on either of these pages. The only place it is covered is the a11y tab. Is that just a result of those changes being in a separate PR? If so, please provide, as it is hard to review this material without knowing what the user has already been told about Callouts on other tabs.

Hi @mbgower Here's a link to the PR that documents the usage and style guidance for Callout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Callout] website docs: a11y tab
5 participants