-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs (notifications a11y): update to new template #4270
base: main
Are you sure you want to change the base?
docs (notifications a11y): update to new template #4270
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @benjamin-kurien, just adding a comment on the images. The tab stop curvature looked a little inconsistent (based on the perpendicular logic) so I have attempted an exploration here (but, this is in 3:2 aspect ratio and not the 16:9 as recommended in the crit-call)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this was a good catch, @alina-jacob. You are totally right. We normally want the line to start going straight up for just a little bit before it starts curving. This is why we need to make some components for these arrows. It's easy to miss those nuances. I didn't even notice it at first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me except that one image tweak @alina-jacob found. Once that is fixed its good from my perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this was a good catch, @alina-jacob. You are totally right. We normally want the line to start going straight up for just a little bit before it starts curving. This is why we need to make some components for these arrows. It's easy to miss those nuances. I didn't even notice it at first.
@benjamin-kurien as I mentioned on a prior call, the accessibility content is normally built to complement information already provided in the Usage and Style tabs; however, when I look at the deployment preview, there is no occurrence of the word "Callout" on either of these pages. The only place it is covered is the a11y tab. |
Hi @mbgower Here's a link to the PR that documents the usage and style guidance for Callout |
Closes #4253
Accessibility document for notification, updated to follow the new template.
Changelog
New
Changed
Removed