docs(tile) feature flag usage, style, code tab update #4266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
laurenmrice
requested review from
Kritvi-bhatia17
and removed request for
RichKummer
thyhmdo
reviewed
Sep 24, 2024
| - The `enable-experimental-tile-contrast` flag adds a border to the tile with | ||
| improved contrast for accessibility and to visually indicate they are | ||
| operable. | ||
| - The `enable-v12-tile-default-icons` flag enables the rendering of default |
There was a problem hiding this comment.
This seems like a run-on sentence. Here's a suggestion.
Suggested change
| - The `enable-v12-tile-default-icons` flag enables the rendering of default | |
| - The `enable-v12-tile-default-icons` flag enables the rendering of default icons on the clickable variant of a tile, such as the ArrowRight icon for navigation or the Error icon when the tile is disabled. If the user hasn't configured a different icon, these defaults will be used. |
There was a problem hiding this comment.
It's missing the Expandable with interactive elements
| sections below. | ||
| 1. **Container**: Contains all content within a tile. | ||
| 2. **Text**: The text within a tile. | ||
| 3. **Icon**: The icon that visually indicates the tile is selectable. |
There was a problem hiding this comment.
Clarify that this could be either the checkbox or the radio button icon.
There was a problem hiding this comment.
The enabled image appears to be smaller/slightly different position than the featured flag disabled one
There was a problem hiding this comment.
Just check on two images Feature enabled and feature-enabled positions.
There was a problem hiding this comment.
Just check on the Link position in both Hover images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4225
This PR updates the Tile component Usage, Style, and Code tabs to include feature flag information and images. The content on the Usage and Style tabs have also been updated with the new content templates.
Note: Links in various places to the "Feature Flag tab" have not been updated yet, because that page is not live yet.
Changelog
New
Usage:
Style:
Code:
Changed
Removed