-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(Overview & FAQs page) Feature flag update #4259
base: main
Are you sure you want to change the base?
docs(Overview & FAQs page) Feature flag update #4259
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach works, however instead of storing the data in this file I would probably recommend updating the data/components.json
file with something like this
{
"component": "Tile",
"featureFlag": true,
"testing": {
"screenreader": "manual"
}
},
That way all the data is in one place.
and then filter based on that.
Hi @alisonjoseph, thanks for the review. I've updated the I have a quick question: In the Menu button components, the Overflow menu, which is a variant of Menu buttons, has a feature flag, but it doesn't appear in the overview card view. Should I add
Or should I leave it as is for now? Here’s a screenshot for reference of what is currently in the code: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Kritvi! Just a couple things:
Closes #3975
Short description
Changelog
NEW
Components > Overview page > Components tab
Components > Overview page > Feature flag tab
Help > FAQs
CHANGED
Help > FAQs