Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly display modal content overflow indicator #3017

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

eduardmarcinco
Copy link
Contributor

@eduardmarcinco eduardmarcinco commented Sep 30, 2024

Closes #2974

Changelog

Changed:

  • Replaced .cds--modal-content--overflow-indicator with the new updated class .cds--modal-scroll-content.
  • Listen for hasScrollingContent value change and append cds--modal-scroll-content class if true.

@eduardmarcinco eduardmarcinco requested a review from a team as a code owner September 30, 2024 13:36
Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit 9624395
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/66fae7f9f7814200085f52be
😎 Deploy Preview https://deploy-preview-3017--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Akshat55 Akshat55 changed the title fix: modal content overflow fix (#2974) fix: correctly display modal content overflow indicator (#2974) Oct 1, 2024
@Akshat55 Akshat55 changed the title fix: correctly display modal content overflow indicator (#2974) fix: correctly display modal content overflow indicator Oct 1, 2024
@Akshat55 Akshat55 merged commit 1ffde64 into carbon-design-system:master Oct 1, 2024
14 checks passed
Copy link

github-actions bot commented Oct 1, 2024

🎉 This PR is included in version 5.40.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal content overflow doesn't fade
2 participants