Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fluid state for Date picker #2886

Open
Tracked by #2769
Akshat55 opened this issue May 16, 2024 · 5 comments
Open
Tracked by #2769

Add fluid state for Date picker #2886

Akshat55 opened this issue May 16, 2024 · 5 comments
Assignees
Labels
component: Date Picker For Date Picker issues good first issue Good for newcomers Hacktoberfest The smell of pumpkin and hacking is in the air! help wanted Good for outside contribution

Comments

@Akshat55
Copy link
Contributor

Akshat55 commented May 16, 2024

Ref: #2769

@Akshat55 Akshat55 changed the title Date picker Add fluid state for Date picker May 16, 2024
@Akshat55 Akshat55 added help wanted Good for outside contribution good first issue Good for newcomers component: Date Picker For Date Picker issues labels May 16, 2024
@coreset
Copy link

coreset commented Oct 4, 2024

@Akshat55 I wanted to check in to see if this issue is still open for fixes. Please let me know if there's anything I can do to help.

@Akshat55
Copy link
Contributor Author

Akshat55 commented Oct 4, 2024

@coreset Doesn't seem to be the case, would you like me to be assigned to it?

@Akshat55 Akshat55 added the Hacktoberfest The smell of pumpkin and hacking is in the air! label Oct 4, 2024
@coreset
Copy link

coreset commented Oct 5, 2024

HI @Akshat55 Yes, please go ahead and assign me to the issue. I’d be happy to start working on it. Looking forward to contributing!

@eduardmarcinco
Copy link
Contributor

Hello, I actually tried to implement fluid state for date picker couple week ago but hit a wall due to bloated DOM structure that is described in #2822
It looks like PR #2823 needs to be merged before fluid state can be implemented.

Just my 2 cents. Maybe you'll find a way to implement it.

@coreset
Copy link

coreset commented Oct 8, 2024

Hello, I actually tried to implement fluid state for date picker couple week ago but hit a wall due to bloated DOM structure that is described in #2822 It looks like PR #2823 needs to be merged before fluid state can be implemented.

Just my 2 cents. Maybe you'll find a way to implement it.

@eduardmarcinco thank you for sharing your insights! I appreciate the context regarding the challenges you faced with the fluid state for the date picker. I'll take a closer look at PR #2823 and see how it can help in moving forward with this implementation. Your input is valuable, and I'll keep you posted on any progress or discoveries I make. My goal is fix this without breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Date Picker For Date Picker issues good first issue Good for newcomers Hacktoberfest The smell of pumpkin and hacking is in the air! help wanted Good for outside contribution
Projects
Status: Featured
Development

No branches or pull requests

3 participants