Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocatable package v5 #2447

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Relocatable package v5 #2447

merged 1 commit into from
Aug 19, 2024

Conversation

mrexodia
Copy link
Contributor

As per #2431

@mrexodia mrexodia changed the base branch from next to v5 August 16, 2024 12:26
@mrexodia mrexodia mentioned this pull request Aug 16, 2024
Merged
2 tasks
@Rot127
Copy link
Collaborator

Rot127 commented Aug 18, 2024

Let's wait until we merged something into v5 (like #2443), rebase this one and get the CI results again.

Just wouldn't want to merge CMake edits without the CI running before.

@Rot127 Rot127 added the build & packaging Build system and packaging related label Aug 18, 2024
@mrexodia
Copy link
Contributor Author

mrexodia commented Aug 18, 2024 •
edited
Loading

I triggered the CI (git commit --amend, git push --force)

Rot127
Rot127 approved these changes Aug 18, 2024
View reviewed changes
Copy link
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes. This is indeed the smart way :)

kabeor
kabeor approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@kabeor kabeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks.

@kabeor kabeor merged commit 041ec63 into capstone-engine:v5 Aug 19, 2024
16 checks passed
@Rot127 Rot127 added this to the v5.0.3 milestone Aug 19, 2024
@BrewTestBot BrewTestBot mentioned this pull request Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rot127 Rot127 Rot127 approved these changes

@kabeor kabeor kabeor approved these changes

Assignees
No one assigned
Labels
build & packaging Build system and packaging related
Projects
None yet
Milestone
v5.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mrexodia @Rot127 @kabeor