Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] Wheel build fixes: manylinux1, trigger upload on release, Linux AArch64... #2444

Merged
merged 9 commits into from
Aug 19, 2024

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Aug 16, 2024

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Fixes several issues:

Test plan

Only one attempted upload (failing job published):
https://github.com/Rot127/capstone/actions

Lists correct wheels in: https://github.com/Rot127/capstone/actions/runs/10448404651

Closing issues

closes #2449

@Rot127 Rot127 added the build & packaging Build system and packaging related label Aug 16, 2024
@Rot127 Rot127 marked this pull request as draft August 16, 2024 05:27
@Rot127 Rot127 changed the title Add AArch64 linux build again. [next] Wheel build fixes: manylinux1, trigger upload on release, Linux AArch64... Aug 16, 2024
@Rot127 Rot127 marked this pull request as ready for review August 16, 2024 07:08
@doronz88
Copy link

I'm not sure but possibly needing to add merge-multiple: true to download-artifacts as described in #2449 as the latest arm64 remains broken with latest version

@Rot127
Copy link
Collaborator Author

Rot127 commented Aug 19, 2024

Ah ok, now I get what you mean. Let me quickly check the docs of gh-action-pypi-publish action again. This behavior seems weird to me.

@github-actions github-actions bot added the python bindings label Aug 19, 2024
@kabeor kabeor merged commit 42d3acf into capstone-engine:next Aug 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build & packaging Build system and packaging related python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Universal wheel for macOS contains only x86_64 build
3 participants