Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] Updates and fixes to the Python wheel builder workflow #2441

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Aug 15, 2024

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Fixes several issues with the binaries in the Python wheels:

  • MacOS wheels are built now for x86_64, AArch64 and universal2 (AArch64, x86_64).
  • Win32 build is removed because cibuildwheel doesn't set the relevant build flags and I currently don't want to put the effort in a basically EOL platform (people can easily build it themselves).
  • A test script is added to check if the binaries are actually built for the correct architectures.
  • Linux AArch64 build is removed for now due to manylinux1_aarch64 is an undefined platform but gets built pypa/cibuildwheel#1972
  • Bump some actions to the next version.

Test plan

Added

Closing issues

closes #2154
closes #2102

@Rot127 Rot127 added the build & packaging Build system and packaging related label Aug 15, 2024
@Rot127 Rot127 added this to the v6 - Alpha milestone Aug 15, 2024
@kabeor kabeor merged commit 5e6807b into capstone-engine:next Aug 15, 2024
19 checks passed
@Rot127 Rot127 deleted the next-uni-wheel branch August 16, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build & packaging Build system and packaging related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Universal wheel for macOS contains only x86_64 build Wheel for aarch64 broken since yesterday
2 participants