Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'make check' for python tests #2439

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

hamarituc
Copy link
Contributor

Your checklist for this pull request

  • not applicable --> I've documented or updated the documentation of every API function and struct this PR changes.
  • not applicable --> I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

The python tests were relocated to a subdirectory, but the check target in the Makefile wasn't changed accordingly. This PR changes the Makefile to execute the checks from the subdirectory.

Test plan

  • Build Capstone with Python bindings
  • Run make check

Closing issues

N/A

Copy link
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general a valid fix of course. But the Makefile build is considered deprecated.
We will go full cmake with v6. But let's merge this nonetheless.

Copy link
Member

@kabeor kabeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@kabeor kabeor merged commit 78eee13 into capstone-engine:next Aug 19, 2024
19 checks passed
@hamarituc hamarituc deleted the python-tests branch August 19, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants