Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Warning C4098: void returns value. #2362

Merged
merged 1 commit into from
May 31, 2024
Merged

Fix Warning C4098: void returns value. #2362

merged 1 commit into from
May 31, 2024

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented May 22, 2024

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Fixes some warnings from MSVC about void functions returning values.

Test plan

All green

Closing issues

...

@github-actions github-actions bot added ARM Arch Alpha Arch PowerPC Arch labels May 22, 2024
XVilka
XVilka approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restart failed jobs - it's the network problem.

@Rot127
Copy link
Collaborator Author

Rot127 commented May 22, 2024

Do it tomorrow. Locally it still fails for me.

@XVilka
Copy link
Contributor

XVilka commented May 25, 2024

@kabeor could you please merge this one?

@kabeor kabeor merged commit 3a6331b into capstone-engine:next May 31, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka approved these changes

@wargio wargio wargio approved these changes

Assignees
No one assigned
Labels
Alpha Arch ARM Arch PowerPC Arch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rot127 @XVilka @wargio @kabeor