Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-sync: Fix some tree-sitter queries #2255

Merged

Conversation

kazarmy
Copy link
Contributor

@kazarmy kazarmy commented Jan 19, 2024

This pr fixes some auto-sync patch tree-sitter queries so that when the auto-sync ASUpdater.py is invoked, tree-sitter doesn't abort with a tree-sitter SyntaxError (which looks almost like a Python SyntaxError except that it has a can-be-unhelpful offset).

@jiegec
Copy link
Contributor

jiegec commented Jan 20, 2024

Thanks, it solves my problem running ASUpdater.py -a AArch64.

@jiegec
Copy link
Contributor

jiegec commented Jan 20, 2024

There are some missing folders though: translate_out, diff_out or maybe some more.

Copy link
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kabeor please take a look.

@kazarmy
Copy link
Contributor Author

kazarmy commented Jan 20, 2024

There are some missing folders though: translate_out, diff_out or maybe some more.

I added the missing output folders manually in response to error messages. The adding only needs to be done once.

@kabeor
Copy link
Member

kabeor commented Jan 20, 2024

Great, thank you!

@kabeor kabeor merged commit 61273ff into capstone-engine:next Jan 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants