Fix crash on x86 when building with MSVC #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a compiler bug in latest MSVC, which at the time of writing is 19.36.32535: given `switch (x)`, where `x` is 64 bits wide, the compiler generates code that computes an incorrect jump table index. E.g. if `x` is zero, it ends up reading the table entry at index -1.
Rot127
added a commit
to Rot127/llvm-capstone
that referenced
this pull request
Jan 19, 2024
Rot127
approved these changes
Jan 19, 2024
|
The labeler CI job should be either restarted or ignored |
github-actions
bot
added
X86
Rot127
added a commit
to capstone-engine/llvm-capstone
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an MSVC compiler bug (still as of 19.36.32535): given
switch (x), wherexis 64 bits wide, the compiler generates code that computes an incorrect jump table index. E.g. ifxis zero, it ends up reading the table entry at index -1.