Add support for architecture registration #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rot127
requested changes
Jan 19, 2024
There was a problem hiding this comment.
The CAPSTONE_USE_ARCH_REGISTRATION is missing in the cmake build (docs and CMakeLists.txt). So cmake will complain:
cmake .. -DCAPSTONE_USE_ARCH_REGISTRATION=1
Enabling CAPSTONE_ARM_SUPPORT
Enabling CAPSTONE_AARCH64_SUPPORT
...
Enabling CAPSTONE_TRICORE_SUPPORT
Enabling CAPSTONE_ALPHA_SUPPORT
-- Configuring done (0.0s)
-- Generating done (0.1s)
CMake Warning:
Manually-specified variables were not used by the project:
CAPSTONE_USE_ARCH_REGISTRATION
-- Build files have been written to: /home/user/repos/capstone/build
Please update is as well. You can ignore the make build. It's considered deprecated.
To support building a static Capstone with many supported architectures and only paying for the ones needed in each consumer. In this way they won't have to build multiple copies of Capstone to minimize footprint.
oleavr
force-pushed
the
feature/explicit-arch-registration
branch
from
4fab200
to
2663e20
Compare
|
@Rot127 Thanks for reviewing! The review feedback should now be addressed. |
XVilka
approved these changes
Jan 19, 2024
Rot127
approved these changes
Jan 20, 2024
|
Cool, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support building a static Capstone with many supported architectures and only paying for the ones needed in each consumer. In this way they won't have to build multiple copies of Capstone to minimize footprint.