Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MSVC warning overrides when using non-MSVC toolchains #2250

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Fix MSVC warning overrides when using non-MSVC toolchains #2250

merged 1 commit into from
Jan 20, 2024

Conversation

oleavr
Copy link
Contributor

@oleavr oleavr commented Jan 18, 2024

The checks should detect MSVC instead of the OS type.

@oleavr
Fix MSVC warning overrides when using non-MSVC toolchains
c3807ea 
The checks should detect MSVC instead of the OS type.
@github-actions github-actions bot added X86 Arch XCore Arch CS-core-files auto-sync labels Jan 18, 2024
Rot127
Rot127 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But don't have a windows machine. @kabeor do you?

XVilka
XVilka reviewed Jan 19, 2024
View reviewed changes
Copy link
Contributor

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to check it with Clang on Windows (clang-cl) as well, as we use it in the AppVeyor CI job.

@kabeor
Copy link
Member

kabeor commented Jan 20, 2024

LGTM, It runs normally on the current windows CI, merging for now.

@kabeor kabeor merged commit fe35325 into capstone-engine:next Jan 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka left review comments

@Rot127 Rot127 Rot127 approved these changes

Assignees
No one assigned
Labels
CS-core-files auto-sync X86 Arch XCore Arch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oleavr @kabeor @XVilka @Rot127