Include _custom_build in sdist #369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes build issues for installations that cannot use wheels published on PyPI. Issue capnproto#364 would be fixed by this. Python build tools like `python -m build` first build a source distribuiton (sdist) and then use it (and only it) to build a binary wheel from. This doesn't work if one of the build scripts isn't in the sdist however, which was the case prior to this patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes build issues for installations that cannot use wheels published on PyPI. Issue #364 would be fixed by this.
Python build tools like
python -m buildfirst build a source distribuiton (sdist) and then use it (and only it) to build a binary wheel from. This doesn't work if one of the build scripts isn't in the sdist however, which was the case prior to this patch.