Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing node12 deprecation warnings #64

Open
wants to merge 1 commit into
base: node10
Choose a base branch
from

Conversation

haata
Copy link

@haata haata commented Nov 23, 2020

  • NewFromUtf8
  • Get
  • Set
  • ToString

- NewFromUtf8
- Get
- Set
- ToString
@kentonv
Copy link
Member

kentonv commented Nov 30, 2020

Hmm, what V8 really wants people to do is to stop calling GetCurrent() all over the place and instead pass down the isolate/context/etc. from the FunctionCallbackInfo. So this feels a little sad to deal with all the deprecations by working around them.

Also sad to be using Check() all over the place instead of propagating the exception, which is what V8 really wants us to do.

But, not sure how much effort it's worth to try to do it right...

@haata
Copy link
Author

haata commented Dec 1, 2020

I might have some time to work on cleaning things up, still learning how V8 is put together.
I've been trying to track down a compiler/linker error on Arch Linux and was hoping to cut down on a bunch of the deprecation noise.

(My end goal is to integrate capnproto into an electron app).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants