Replace ErrorReporter with a structured logging interface. #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new interface: - Has levels (debug, info, warn, error) - Accepts arguments for structured logging Per the comments, the interface is designed to be used with *slog.Logger, though other implementations are possible (and we already use one in test).
|
Note that there's some followup refactoring to do, such as getting rid of the use of ReportError() internally, and perhaps actually using the lower logging levels for non-fatal events. |
lthibault
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new interface:
Per the comments, the interface is designed to be used with *slog.Logger, though other implementations are possible (and we already use one in test).