Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log levels for error reporter #535

Closed
zenhack opened this issue Jun 29, 2023 · 2 comments
Closed

Log levels for error reporter #535

zenhack opened this issue Jun 29, 2023 · 2 comments
Assignees

Comments

@zenhack
Copy link
Contributor

zenhack commented Jun 29, 2023

This has come up a couple times on matrix now: it would be nice to have something like log levels in ErrorReporter; in particular, here are a few things I'd like to be able to filter differently:

  • Protocol errors
  • Disconnects
  • Soon, with 3PH: falling back to using a vine, when forming a direct connection fails

We could go all in and just accept a Logger from the new slog package: https://pkg.go.dev/golang.org/x/exp/slog#Logger

Though I worry this might bloat code size, which I want to avoid for the frontend code in tempest. We could also define an interface with the log levels we care about that Logger satisfies.

@philippgille
Copy link

Some related work seems to have been done already: #537

@lthibault
Copy link
Collaborator

@philippgille Indeed. I have to go through Ian's PR to see how much of this is covered by the addition of the logging interface. I think this issue might technically be resolved already.

@lthibault lthibault self-assigned this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants