Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imbue builders and readers with cap tables #131

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vaci
Copy link
Contributor

@vaci vaci commented Dec 27, 2022

In order to implement the RPC features of Capnproto in Java, the most intrusive change to the existing codebase is to imbue builders and readers with the tables for tracking references to any capabilities that may be associated with an arena.

This patch does the trivial but tedious work of wiring capability tables into builders and readers. Backward compatibility is maintained in existing method signatures by defaulting the optional capTable parameter to null.

@vaci vaci force-pushed the vaci/cap-table branch 6 times, most recently from fed5efc to 40f1b2a Compare December 27, 2022 15:47
@vaci vaci marked this pull request as ready for review December 27, 2022 15:48
@mikehearn
Copy link

Is there a reason this was never reviewed? Is the intention to never add RPC support to the Java implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants