Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignores webpacker assets when deciding if things have changed since last release #30

Open
hishammalik opened this issue Dec 6, 2017 · 7 comments

Comments

@hishammalik
Copy link

This gem does not take into account changes to the webpacker assets and as a result the assets:precompile tasks gets incorrectly ignored.

@adrianthedev
Copy link

Yea, this would be a great addition with the new webpacker gem

@alpracka
Copy link

alpracka commented Oct 9, 2018

Edit deploy.rb

and include "app/javascript" to asset_dependencies, e.g.:

set :assets_dependencies, %w(app/javascript app/assets lib/assets vendor/assets Gemfile.lock config/routes.rb node_modules)

and add "public/packs" to linked dirs:

set :linked_dirs, fetch(:linked_dirs, []).push('public/packs')

@brandoncordell
Copy link

set :assets_dependencies, %w(app/javascript app/assets lib/assets vendor/assets Gemfile.lock config/routes.rb node_modules)

Everything under node_modules is showing different on every deploy so it's kicking off the compilation of my webpacker stuff even when nothing changes.

Any idea why it's happening or how to get around it?

@alpracka
Copy link

Try to add node_modules folder to linked dirs:

set :linked_dirs, fetch(:linked_dirs, []).push('node_modules')

or try to add node_modules folder to your repository (in case of Git - you might have node_modules written in .gitignore filte.

@soundnotation
Copy link

I also have the same problem. Adding public/packs to linked_dirs didn't work, nor does node_modules. Plus, committing node_modules to Git is a very bad idea.

@PabloC
Copy link

PabloC commented Feb 24, 2021

+1

1 similar comment
@emanalkhaldiyebab
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants