Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Helm release handler for Helm storage backend #671

Closed
Tracked by #650
pkosiec opened this issue Mar 16, 2022 · 0 comments · Fixed by capactio/hub-manifests#62 or #677
Closed
Tracked by #650

Implement Helm release handler for Helm storage backend #671

pkosiec opened this issue Mar 16, 2022 · 0 comments · Fixed by capactio/hub-manifests#62 or #677
Assignees
Labels
area/hub Relates to Hub enhancement New feature or request
Milestone

Comments

@pkosiec
Copy link
Member

pkosiec commented Mar 16, 2022

Description

Implement Helm release storage backend:

  • Extend Helm backend under /cmd/helm-storage-backend. Implement gRPC server. Types are already generated.
    • Support all possible releases backends (ConfigMap/Secret/etc). Maybe we will need to extend the backend.context to allow specifying it.
    • Support only GetValue method, the rest just validate data (e.g. onDelete checks whether a given Helm release exist).
      • To consider what exactly we want to validate - Should we really return error if a given Helm release doesn't exist in OnDelete method? It could be deleted externally. Or perhaps we just need to validate that in onCreate, onUpdate, and locking/unlocking? 🤔
  • Helm backend Type manifests is already defined. Ensure that it is up-to-date at the end of the task.
  • Keep the same shape of data: https://github.com/capactio/hub-manifests/blob/main/manifests/type/helm/chart/release.yaml

Related issues

See epic #650

@pkosiec pkosiec added this to the 0.7.0 milestone Mar 16, 2022
@pkosiec pkosiec added enhancement New feature or request area/hub Relates to Hub labels Mar 16, 2022
@pkosiec pkosiec changed the title Helm release backend implementation [1MD] Helm release backend implementation Mar 16, 2022
@pkosiec pkosiec changed the title Helm release backend implementation Implement Helm release handler for Helm storage backend Mar 16, 2022
@mszostok mszostok self-assigned this Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hub Relates to Hub enhancement New feature or request
Projects
None yet
2 participants