Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of sed usage inside Capact release pipeline scripts #622

Open
pkosiec opened this issue Jan 28, 2022 · 0 comments
Open

Get rid of sed usage inside Capact release pipeline scripts #622

pkosiec opened this issue Jan 28, 2022 · 0 comments
Labels
area/ci Relates to CI enhancement New feature or request needs-triage Relates to issues that should be refined

Comments

@pkosiec
Copy link
Member

pkosiec commented Jan 28, 2022

Description

Refactor hack/make-release.sh and hack/release-charts.sh script:

  • Get rid of error-prone sed usage

Alternatives:

See the discussion #617

Reason

The current solution is very shortsighted. In case of Dashboard tag, the current approach replaces any tag property, which is a generic word. It's a matter of time when we have such duplicated property in the values.yaml file. Same with other properties, like branch, which could occur multiple times, as we have multiple sources support in Populator. Should we build more complex sed one-liners in future? Definitely not, so that would need to be addressed.

@pkosiec pkosiec added enhancement New feature or request needs-triage Relates to issues that should be refined area/ci Relates to CI labels Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Relates to CI enhancement New feature or request needs-triage Relates to issues that should be refined
Projects
None yet
Development

No branches or pull requests

1 participant