Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare PoC for generic upload of TypeInstances even if Action failed #563

Open
mszostok opened this issue Nov 16, 2021 · 0 comments
Open
Labels
area/cli Relates to CLI area/documentation Related to all activities around documentation area/engine Relates to Engine area/hub Relates to Hub enhancement New feature or request
Milestone

Comments

@mszostok
Copy link
Member

mszostok commented Nov 16, 2021

Description

Prepare PoC for generic upload of TypeInstances even if Action failed.

Currently, the upload TypeInstance step is the last one, and it's executed only if all other step exited with non-zero code.
This is problematic as in case of failed Action we don't have TypeInstances generated in previous steps.

AC

Even if Action fails:

  1. TypeInstances from successfully finished steps are uploaded to Local Hub
  2. We still built the relations between uploaded TypeInstances (as much as we can, ignoring missing TypeInstances)
  3. We see uploaded TypeInstance under Action status (.Actions[0].output.typeInstances).

Reason

To get the output of executed step (TypeInstances) for failed Action we need to download it directly from MinIO. It requires a lot of manual steps. Additionally, it generates a second problem, sometimes the format of artifacts from MinIO are different from the final TypeInstances format.

This enables also a rollback (#502) for failed Action too.

Use cases

  • System User - enables and option to easily get the output of executed step from failed Action, e.g., to download the Terraform state and execute clean-up.
@mszostok mszostok added enhancement New feature or request area/engine Relates to Engine area/hub Relates to Hub area/cli Relates to CLI area/documentation Related to all activities around documentation labels Nov 16, 2021
@mszostok mszostok added this to the 0.6.0 milestone Nov 16, 2021
@mszostok mszostok modified the milestones: 0.6.0, 0.7.0, Next Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Relates to CLI area/documentation Related to all activities around documentation area/engine Relates to Engine area/hub Relates to Hub enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant