Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue form: set rockcraft.yaml field to render as YAML. #684

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

aznashwan
Copy link
Contributor

  • Have you signed the CLA?

@aznashwan
Copy link
Contributor Author

Test of the change in effect can be seen on my fork here: aznashwan#1

@lengau lengau requested a review from tigarmo August 27, 2024 21:32
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks

Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! Good eye

github-merge-queue bot pushed a commit to canonical/charmcraft that referenced this pull request Aug 28, 2024
@tigarmo tigarmo merged commit ac97850 into canonical:main Aug 29, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants