Vastly simplify PR template #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find that PR templates/checklists do more harm than good. Half of the stuff is irrelevant to most PRs, so people tend to start ignoring the checklist anyway. And there are a ton of things that aren't in the checklist that should be checked -- but the list would be very unwieldy if we tried to be exhaustive. I'd rather people just wrote good, English descriptions, and edit them where they need improvement. So this PR simplifies it to the point of basically removing it. :-)
|
Any strong objections, @jnsgruk? |
jnsgruk
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find that PR templates/checklists do more harm than good. Half of the stuff is irrelevant to most PRs, so people tend to start ignoring the checklist anyway. And there are a ton of things that aren't in the checklist that should be checked -- but the list would be very unwieldy if we tried to be exhaustive.
I'd rather people just wrote good, English descriptions, and edit them where they need improvement.
So this PR simplifies it to the point of basically removing it. :-)