-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update charm pins #1390
chore: update charm pins #1390
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the three disabled tests has had the linked PR merged, but the other two have not. I'm not sure why the tests are all passing without that - I'll look into it.
(I do love the way that this automation drops the disabled comment when everything is fine again).
With this: diff --git a/requirements.txt b/requirements.txt
index 29ba811..ea137a2 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,7 +1,8 @@
cosl
cryptography
jsonschema
-ops
+#ops
+git+https://github.com/canonical/operator
pyaml
requests
lightkube >= 0.11 I get this locally, with
|
Ah, actually this is the problem when I look more closely. It's not removing the disabled comment, it's removing all the comments which also removes some of the repos to check against, and that's why things are passing. |
Ahhh!!! maybe a solution is to have separate comment nodes? |
Co-authored-by: Tony Meyer <[email protected]>
Co-authored-by: Tony Meyer <[email protected]>
How do I keep getting this wrong?
This is an automated PR to update pins of the external repositories that the operator framework is tested against --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Dima Tisnek <[email protected]> Co-authored-by: Tony Meyer <[email protected]>
This is an automated PR to update pins of the external repositories that the operator framework is tested against