Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update charm pins #1390

Merged
merged 7 commits into from
Sep 25, 2024
Merged

Conversation

benhoyt
Copy link
Collaborator

@benhoyt benhoyt commented Sep 25, 2024

This is an automated PR to update pins of the external repositories that the operator framework is tested against

Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the three disabled tests has had the linked PR merged, but the other two have not. I'm not sure why the tests are all passing without that - I'll look into it.

(I do love the way that this automation drops the disabled comment when everything is fine again).

@tonyandrewmeyer
Copy link
Contributor

With this:

diff --git a/requirements.txt b/requirements.txt
index 29ba811..ea137a2 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,7 +1,8 @@
 cosl
 cryptography
 jsonschema
-ops
+#ops
+git+https://github.com/canonical/operator
 pyaml
 requests
 lightkube >= 0.11

I get this locally, with 1bd9e7fd96a9f5a91443e5932667c58a92c1ce5e:

============================ 24 failed, 114 passed, 4 warnings in 3.94s ============================

@tonyandrewmeyer
Copy link
Contributor

(I do love the way that this automation drops the disabled comment when everything is fine again).

Ah, actually this is the problem when I look more closely. It's not removing the disabled comment, it's removing all the comments which also removes some of the repos to check against, and that's why things are passing.

@dimaqq
Copy link
Contributor

dimaqq commented Sep 25, 2024

(I do love the way that this automation drops the disabled comment when everything is fine again).

Ah, actually this is the problem when I look more closely. It's not removing the disabled comment, it's removing all the comments which also removes some of the repos to check against, and that's why things are passing.

Ahhh!!! maybe a solution is to have separate comment nodes?
I tried to be round-trip safe with yaml, but there's only so much I can do.

How do I keep getting this wrong?
@tonyandrewmeyer tonyandrewmeyer merged commit d5eadcb into main Sep 25, 2024
30 checks passed
@tonyandrewmeyer tonyandrewmeyer deleted the auto-update-external-charm-pins branch September 25, 2024 07:26
tonyandrewmeyer added a commit to tonyandrewmeyer/operator that referenced this pull request Oct 4, 2024
This is an automated PR to update pins of the external repositories that
the operator framework is tested against

---------

Co-authored-by: github-actions <[email protected]>
Co-authored-by: Dima Tisnek <[email protected]>
Co-authored-by: Tony Meyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants