-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: re-enable integration tests with mysql-*operator #1013
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyandrewmeyer
changed the title
ci: adjust pyproject.toml if it exists and requirements.txt does not
ci: re-enable integration tests with mysql-operator and mysql-k8s-operator
Sep 25, 2023
Manipulate pyproject.toml, but refer to the local checkout not git.
benhoyt
reviewed
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me -- one question, and one minor tweak requested on the poetry version.
benhoyt
changed the title
ci: re-enable integration tests with mysql-operator and mysql-k8s-operator
ci: re-enable integration tests with mysql-*operator
Sep 26, 2023
* Pin all tox's to anything compatible with 4.2 * Pin poetry to anything compatible with 1.6 * Remove the 'static-charm' tox run from the DB workflow, as none of the repositories have that target, and more recent versions of tox will fail if the target (env) doesn't exist.
benhoyt
approved these changes
Sep 27, 2023
Thanks! CI improvements, merging without further review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requirements.txt
if it existsrequirements.txt
does not exist, then assume that the requirement is inpyproject.toml
and edit that insteadmysql-operator
andmysql-k8s-operator
againstatic-charm
tox runs from the DB workflow, as none of the DB operators have one definedtox
to anything compatible with 4.2Note that bash/sed is not a personal strength, so there could well be a nicer way to do this.
Fixes #987.