Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pull_path doesn't retrieve empty directories #968

Closed
benhoyt opened this issue Jul 10, 2023 · 0 comments · Fixed by #1024
Closed

pull_path doesn't retrieve empty directories #968

benhoyt opened this issue Jul 10, 2023 · 0 comments · Fixed by #1024
Assignees
@tonyandrewmeyer
Labels
bug Something isn't working small item

Comments

@benhoyt
Copy link
Collaborator

benhoyt commented Jul 10, 2023

Per this comment, Container.pull_path doesn't retrieve empty directories. This seems like a bug, not a feature (Git's behaviour notwithstanding). From a quick look at the code, I think push_path will have a similar problem.

We probably need to change the _list_recursive helper to also yield directories (before recursing), and the callers test if it's a directory and create it, otherwise copy the file.
@benhoyt benhoyt mentioned this issue Jul 10, 2023
Merged
@benhoyt benhoyt added bug Something isn't working and removed good first item labels Sep 29, 2023
@tonyandrewmeyer tonyandrewmeyer mentioned this issue Oct 2, 2023
Merged
benhoyt pushed a commit that referenced this issue Oct 4, 2023
@tonyandrewmeyer
fix: push_path and pull_path include empty directories (#1024)
942bd23 
Instead of just recursively iterating through the remote/local files,
also iterate through the directories as well, ensuring that they are
created even if they don't contain any files.

Also create/update relevant test cases.

Fixes #968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyandrewmeyer tonyandrewmeyer

Labels
bug Something isn't working small item
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: push_path and pull_path include empty directories tonyandrewmeyer/operator
2 participants
@tonyandrewmeyer @benhoyt