Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netplan: Improve 'How-to contribute to docs' #122

Open
rkratky opened this issue Aug 2, 2024 · 6 comments
Open

Netplan: Improve 'How-to contribute to docs' #122

rkratky opened this issue Aug 2, 2024 · 6 comments
Assignees
Labels
how-to Create a edit a how-to to achieve a specific task size 2 Fix a known documentation issue (size 2/8) update Update potentially outdated instructions, commands, or version numbers

Comments

@rkratky
Copy link
Collaborator

rkratky commented Aug 2, 2024

Context

While the Netplan docs include a how-to article with guidance on contributing to the documentation set, it could be improved by:

  • Making it better findable
  • Adding info about things one needs to know when submitting PRs to the Netplan repo

Task

  1. Move the Contribute to docs article from the How-to section in the navigation to the top level, i.e. as a standalone link under the four Diátaxis categories in the left-hand sidebar.
  2. Add a section to this how-to that would prepare the contributor for what's required when submitting a Netplan PR:
    • Short explanation of tests that need to be run in the repo's main directory
    • Prerequisites needed for the test suites to function

Reference

@rkratky rkratky added size 2 Fix a known documentation issue (size 2/8) how-to Create a edit a how-to to achieve a specific task update Update potentially outdated instructions, commands, or version numbers labels Aug 2, 2024
@davidekete
Copy link
Contributor

Hi @rkratky, I'd like to work on this

@rkratky
Copy link
Collaborator Author

rkratky commented Aug 2, 2024

Nice. Just assigned the issue to you.

@davidekete
Copy link
Contributor

davidekete commented Aug 18, 2024

Hi @rkratky, I noticed another issue with the contribute to docs tutorial. It mentions that "All the documentation files are located in the doc/ directory. The doc/ directory contains sub-directories corresponding to different Diátaxis sections". This statement is wrong; the doc/ directory contains no sub-directories corresponding to different Diátaxis sections.

Can we create another issue to sort this out? We can edit the section to reflect the actual directory structure or arrange the files into their corresponding sub-directories.

@rkratky
Copy link
Collaborator Author

rkratky commented Aug 19, 2024

Right, that's an oversight -- using the doc/ directory is the usual set up, and we forgot this was not the case for Netplan when adopting the contrib. guide.

OK, I'm creating ano0ther issue to deal with that particular discrepancy. Please, ignore that part while working on this issue.

@davidekete
Copy link
Contributor

Right, that's an oversight -- using the doc/ directory is the usual set up, and we forgot this was not the case for Netplan when adopting the contrib. guide.

OK, I'm creating ano0ther issue to deal with that particular discrepancy. Please, ignore that part while working on this issue.

Alright, please let me know when you create the issue so you can assign it to me.

@rkratky
Copy link
Collaborator Author

rkratky commented Aug 19, 2024

#125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
how-to Create a edit a how-to to achieve a specific task size 2 Fix a known documentation issue (size 2/8) update Update potentially outdated instructions, commands, or version numbers
Projects
None yet
Development

No branches or pull requests

2 participants