From 320408e7aea6b80766ec39c6565d257712d74e9c Mon Sep 17 00:00:00 2001 From: Mark Laing Date: Wed, 30 Oct 2024 09:41:40 +0100 Subject: [PATCH] WIP Signed-off-by: Mark Laing --- lxd/instance_put.go | 207 +------------------------------------------- 1 file changed, 1 insertion(+), 206 deletions(-) diff --git a/lxd/instance_put.go b/lxd/instance_put.go index 563a3aed28f9..7b961bd08839 100644 --- a/lxd/instance_put.go +++ b/lxd/instance_put.go @@ -1,32 +1,9 @@ package main import ( - "context" - "encoding/json" - "fmt" "net/http" - "net/url" - "github.com/google/uuid" - "github.com/gorilla/mux" - - "github.com/canonical/lxd/lxd/db" - "github.com/canonical/lxd/lxd/db/cluster" - "github.com/canonical/lxd/lxd/db/operationtype" - deviceConfig "github.com/canonical/lxd/lxd/device/config" - "github.com/canonical/lxd/lxd/instance" - "github.com/canonical/lxd/lxd/instance/instancetype" - "github.com/canonical/lxd/lxd/operations" - "github.com/canonical/lxd/lxd/project/limits" - "github.com/canonical/lxd/lxd/request" "github.com/canonical/lxd/lxd/response" - "github.com/canonical/lxd/lxd/state" - "github.com/canonical/lxd/lxd/util" - "github.com/canonical/lxd/shared" - "github.com/canonical/lxd/shared/api" - "github.com/canonical/lxd/shared/osarch" - "github.com/canonical/lxd/shared/revert" - "github.com/canonical/lxd/shared/version" ) // swagger:operation PUT /1.0/instances/{name} instances instance_put @@ -61,187 +38,5 @@ import ( // "500": // $ref: "#/responses/InternalServerError" func instancePut(d *Daemon, r *http.Request) response.Response { - // Don't mess with instance while in setup mode. - <-d.waitReady.Done() - - s := d.State() - - instanceType, err := urlInstanceTypeDetect(r) - if err != nil { - return response.SmartError(err) - } - - projectName := request.ProjectParam(r) - - // Get the container - name, err := url.PathUnescape(mux.Vars(r)["name"]) - if err != nil { - return response.SmartError(err) - } - - if shared.IsSnapshot(name) { - return response.BadRequest(fmt.Errorf("Invalid instance name")) - } - - // Handle requests targeted to a container on a different node - resp, err := forwardedResponseIfInstanceIsRemote(s, r, projectName, name, instanceType) - if err != nil { - return response.SmartError(err) - } - - if resp != nil { - return resp - } - - revert := revert.New() - defer revert.Fail() - - unlock, err := instanceOperationLock(s.ShutdownCtx, projectName, name) - if err != nil { - return response.SmartError(err) - } - - revert.Add(func() { - unlock() - }) - - inst, err := instance.LoadByProjectAndName(s, projectName, name) - if err != nil { - return response.SmartError(err) - } - - // Validate the ETag - etag := []any{inst.Architecture(), inst.LocalConfig(), inst.LocalDevices(), inst.IsEphemeral(), inst.Profiles()} - err = util.EtagCheck(r, etag) - if err != nil { - return response.PreconditionFailed(err) - } - - configRaw := api.InstancePut{} - err = json.NewDecoder(r.Body).Decode(&configRaw) - if err != nil { - return response.BadRequest(err) - } - - architecture, err := osarch.ArchitectureId(configRaw.Architecture) - if err != nil { - architecture = 0 - } - - var do func(*operations.Operation) error - var opType operationtype.Type - if configRaw.Restore == "" { - // Check project limits. - apiProfiles := make([]api.Profile, 0, len(configRaw.Profiles)) - err = s.DB.Cluster.Transaction(r.Context(), func(ctx context.Context, tx *db.ClusterTx) error { - profiles, err := cluster.GetProfilesIfEnabled(ctx, tx.Tx(), projectName, configRaw.Profiles) - if err != nil { - return err - } - - profileConfigs, err := cluster.GetConfig(ctx, tx.Tx(), "profile") - if err != nil { - return err - } - - profileDevices, err := cluster.GetDevices(ctx, tx.Tx(), "profile") - if err != nil { - return err - } - - for _, profile := range profiles { - apiProfile, err := profile.ToAPI(ctx, tx.Tx(), profileConfigs, profileDevices) - if err != nil { - return err - } - - apiProfiles = append(apiProfiles, *apiProfile) - } - - return limits.AllowInstanceUpdate(s.GlobalConfig, tx, projectName, name, configRaw, inst.LocalConfig()) - }) - if err != nil { - return response.SmartError(err) - } - - // Update container configuration - do = func(op *operations.Operation) error { - defer unlock() - - args := db.InstanceArgs{ - Architecture: architecture, - Config: configRaw.Config, - Description: configRaw.Description, - Devices: deviceConfig.NewDevices(configRaw.Devices), - Ephemeral: configRaw.Ephemeral, - Profiles: apiProfiles, - Project: projectName, - } - - err = inst.Update(args, true) - if err != nil { - return err - } - - return nil - } - - opType = operationtype.InstanceUpdate - } else { - // Snapshot Restore - do = func(op *operations.Operation) error { - defer unlock() - - return instanceSnapRestore(s, projectName, name, configRaw.Restore, configRaw.Stateful) - } - - opType = operationtype.SnapshotRestore - } - - resources := map[string][]api.URL{} - resources["instances"] = []api.URL{*api.NewURL().Path(version.APIVersion, "instances", name)} - - if inst.Type() == instancetype.Container { - resources["containers"] = resources["instances"] - } - - op, err := operations.OperationCreate(s, projectName, operations.OperationClassTask, opType, resources, nil, do, nil, nil, r) - if err != nil { - return response.InternalError(err) - } - - revert.Success() - return operations.OperationResponse(op) -} - -func instanceSnapRestore(s *state.State, projectName string, name string, snap string, stateful bool) error { - // normalize snapshot name - if !shared.IsSnapshot(snap) { - snap = name + shared.SnapshotDelimiter + snap - } - - inst, err := instance.LoadByProjectAndName(s, projectName, name) - if err != nil { - return err - } - - source, err := instance.LoadByProjectAndName(s, projectName, snap) - if err != nil { - switch { - case response.IsNotFoundError(err): - return fmt.Errorf("Snapshot %s does not exist", snap) - default: - return err - } - } - - // Generate a new `volatile.uuid.generation` to differentiate this instance restored from a snapshot from the original instance. - source.LocalConfig()["volatile.uuid.generation"] = uuid.New().String() - - err = inst.Restore(source, stateful) - if err != nil { - return err - } - - return nil + panic("not implemented") }