-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add loggedin user account related entities and API endpoint interactions #52
Conversation
4c3359b
to
c8b36f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sachin120
Thank you for your contribution 👍
LGTM and +1
May I ask you to resolve the conflict at client/client.go
? If you don't have time, we can take care of that.
c8b36f6
to
23b22e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sachin120,
It seems that you need to create two entities since MAAS returns different response on listing tokens and at create response. Please take a look at the example:
ubuntu@maas-dev:~$ maas admin account create-authorisation-token
Success.
Machine-readable output follows:
{"token_key": "abcabc", "token_secret": "123123", "consumer_key": "!@#!@#", "name": "MAAS consumer"}
ubuntu@maas-dev:~$ maas admin account list-authorisation-tokens
Success.
Machine-readable output follows:
[
{
"name": "MAAS consumer",
"token": "!@#!@#:abcabc:123123"
}
]
So we need an entity for each one of them. Please update your PR and I will be glad to merge it 🙂
I missed it. Thanks @skatsaounis |
23b22e2
to
9f46518
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nitpick, I think AuthorisationTokenListItem
will be a less confusing name for a variable.
9f46518
to
dc7aa24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1 Thanks for yet another contribution 🎉
What does this implement
Added user account-related API