Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Update charmcraft builder from 20.04 to 22.04 #178

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nrobinaubertin
Copy link
Collaborator

Overview

Update charmcraft builder from 20.04 to 22.04

Checklist

Copy link
Contributor

Test coverage for d45938e

Name              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------
src/charm.py        330     30     82     11    90%   177, 185-186, 350->355, 548-550, 555-556, 567-569, 574-575, 587-589, 594-595, 607-609, 634-636, 676->exit, 686->exit, 716-722, 748->exit, 762-763, 773->exit, 787
src/database.py      30      1      8      1    95%   56
-------------------------------------------------------------
TOTAL               360     31     90     12    90%

Static code analysis report

Run started:2024-01-18 12:21:47.548788

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1984
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link
Contributor

@mthaddon mthaddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might not want to go ahead with this due to https://bugs.launchpad.net/juju/+bug/1996590.

@merkata merkata marked this pull request as draft January 18, 2024 12:44
@nrobinaubertin nrobinaubertin changed the title Update charmcraft builder from 20.04 to 22.04 [Do not merge] Update charmcraft builder from 20.04 to 22.04 Jan 18, 2024
@nrobinaubertin nrobinaubertin mentioned this pull request Mar 6, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants