[DPE-2342] data-platform-libs major version change v0/v1 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juditnovak
force-pushed
the
DPE-2342_relation_secrets_v1
branch
from
178c18c
to
1d74140
Compare
juditnovak
force-pushed
the
DPE-2342_relation_secrets_v1
branch
9 times, most recently
from
6290e1e
to
2fed55b
Compare
juditnovak
force-pushed
the
DPE-2342_relation_secrets
branch
from
7481a42
to
1a81c55
Compare
juditnovak
force-pushed
the
DPE-2342_relation_secrets_v1
branch
11 times, most recently
from
d60b3ab
to
0d816f4
Compare
juditnovak
changed the title
juditnovak
force-pushed
the
DPE-2342_relation_secrets_v1
branch
from
0d816f4
to
75f7f1a
Compare
juditnovak
commented
Aug 31, 2023
| @@ -291,32 +291,35 @@ def _on_topic_requested(self, event: TopicRequestedEvent): | |||
| exchanged in the relation databag. | |||
There was a problem hiding this comment.
Please no comments on this module here.
If you would like to discuss the Secrets logic, pls refer to the based PR
juditnovak
commented
Aug 31, 2023
| @@ -291,16 +291,13 @@ def _on_topic_requested(self, event: TopicRequestedEvent): | |||
| exchanged in the relation databag. | |||
There was a problem hiding this comment.
Please no comments on this module here.
If you would like to discuss the Secrets logic, pls refer to the #91
juditnovak
force-pushed
the
DPE-2342_relation_secrets_v1
branch
from
c0f5948
to
081a595
Compare
juditnovak
force-pushed
the
DPE-2342_relation_secrets_v1
branch
2 times, most recently
from
20dd8b7
to
7d04fc0
Compare
juditnovak
force-pushed
the
DPE-2342_relation_secrets
branch
2 times, most recently
from
4e99319
to
44b0c82
Compare
juditnovak
force-pushed
the
DPE-2342_relation_secrets_v1
branch
from
7d04fc0
to
4e36d1e
Compare
juditnovak
force-pushed
the
DPE-2342_relation_secrets
branch
from
44b0c82
to
ec4c19c
Compare
juditnovak
force-pushed
the
DPE-2342_relation_secrets_v1
branch
from
4e36d1e
to
019ab39
Compare
juditnovak
force-pushed
the
DPE-2342_relation_secrets
branch
from
ec4c19c
to
f2b8bc9
Compare
juditnovak
force-pushed
the
DPE-2342_relation_secrets_v1
branch
from
019ab39
to
543a58e
Compare
juditnovak
force-pushed
the
DPE-2342_relation_secrets_v1
branch
from
543a58e
to
c03080b
Compare
juditnovak
force-pushed
the
DPE-2342_relation_secrets
branch
2 times, most recently
from
8ba180c
to
96d890d
Compare
|
@juditnovak is this still topical? |
|
Since we managed to add the change as a minor version, no major version change was needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is introducing a major version change of
data-platform-libs.The reason for this is the contract change between
v0andv1onAuthenticationEvent(and descendants).This PR is present and discuss issues relating to major version restructure and changes.
NOT DISCUSSIONS ON SECRETS LOGIC PLEASE
Thank you.
Any comments on the Relation Secrets logic should go the the based PR.
NOTE to Reviewers - and Reviewers of Reviewers :-) :
Approval on this PR doesn't apply to the based PR. Reviewers, be relieved :-)