Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove trailing spaces where supported #210

Merged
merged 10 commits into from
Sep 12, 2024
Merged

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Dec 2, 2023

Fixes #136
CRAFT-3358

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.83%. Comparing base (99394c9) to head (fd38bb7).
Report is 6 commits behind head on main.

❗ Current head fd38bb7 differs from pull request most recent head 3f19cb1. Consider uploading reports for the commit 3f19cb1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   93.24%   94.83%   +1.59%     
==========================================
  Files           7        7              
  Lines        1080     1084       +4     
  Branches      200      200              
==========================================
+ Hits         1007     1028      +21     
+ Misses         66       53      -13     
+ Partials        7        3       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

craft_cli/printer.py Show resolved Hide resolved
craft_cli/printer.py Outdated Show resolved Hide resolved
@tigarmo
Copy link
Collaborator

tigarmo commented Sep 5, 2024

@lengau I played around with this a bit and it seems to be working fine! That is, no breakage that I could see
One thing that I'd like your opinion on though is the new behavior where the cursor keeps jumping around the row as the line that's printed is shorter or longer; I found that distracting but maybe I'm too close to the issue to get a good sense.

@lengau
Copy link
Contributor Author

lengau commented Sep 11, 2024

@tigarmo based on our team discussions I've created #275 to go along with this and cover the cursor hiding.

Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@lengau lengau merged commit c62ce3a into main Sep 12, 2024
8 checks passed
@lengau lengau deleted the 136-trailing-spaces branch September 12, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove trailing spaces before new line
3 participants