Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verification of the model using wait_for_idle should consider also if application is active #199

Closed
gabrielcocenza opened this issue Dec 12, 2023 · 0 comments · Fixed by #201
Closed

Verification of the model using wait_for_idle should consider also if application is active #199

gabrielcocenza opened this issue Dec 12, 2023 · 0 comments · Fixed by #201
Assignees
@gabrielcocenza
Labels
bug Something isn't working high

Comments

@gabrielcocenza
Copy link
Member

gabrielcocenza commented Dec 12, 2023 •
edited
Loading

I was testing cou on the following bundle and as it is possible to see, one unit of mysql was in maintenance:

App                   Version  Status       Scale  Charm                 Channel        Rev  Exposed  Message
designate-bind        9.16.1   active           1  designate-bind        ussuri/stable   98  no       Unit is ready
mysql-innodb-cluster  8.0.35   maintenance      3  mysql-innodb-cluster  8.0/stable     107  no       Paused. Use 'resume' action to resume normal service.

Unit                     Workload     Agent  Machine  Public address  Ports  Message
designate-bind/0*        active       idle   0        10.101.82.190          Unit is ready
mysql-innodb-cluster/0*  active       idle   1        10.101.82.32           Unit is ready: Mode: R/W, Cluster is NOT tolerant to any failures. 1 member is not active.
mysql-innodb-cluster/1   active       idle   2        10.101.82.151          Unit is ready: Mode: R/O, Cluster is NOT tolerant to any failures. 1 member is not active.
mysql-innodb-cluster/2   maintenance  idle   3        10.101.82.241          Paused. Use 'resume' action to resume normal service.

This initial check should fail in such situation and also after the upgrade if some unit is still on maintenance.
@agileshaw agileshaw added bug Something isn't working high labels Dec 12, 2023
@gabrielcocenza gabrielcocenza self-assigned this Dec 13, 2023
gabrielcocenza added a commit to gabrielcocenza/charmed-openstack-upgrader-1 that referenced this issue Dec 13, 2023
@gabrielcocenza
Check if applications are active/idle before upgrading.
6d3ec56 
- Without status check if the unit is on maintenance it will
  proceed to upgrade

Closes: canonical#199
@gabrielcocenza gabrielcocenza mentioned this issue Dec 13, 2023
Merged
gabrielcocenza added a commit to gabrielcocenza/charmed-openstack-upgrader-1 that referenced this issue Dec 13, 2023
@gabrielcocenza
Check if applications are active/idle before upgrading.
0a2f680 
- Without status check if the unit is on maintenance it will
  proceed to upgrade

Closes: canonical#199
@gabrielcocenza gabrielcocenza changed the title Verify that all OpenStack applications are in idle state should include wait_for_active=True Verification of the model using wait_for_idle should consider also if application is active Dec 13, 2023
gabrielcocenza added a commit to gabrielcocenza/charmed-openstack-upgrader-1 that referenced this issue Dec 13, 2023
@gabrielcocenza
Check if applications status are active on wait_for_idle.
8ad098f 
- Without status check if the unit is on maintenance it will
  proceed to upgrade or pass the post upgrade step.

Closes: canonical#199
gabrielcocenza added a commit that referenced this issue Dec 15, 2023
@gabrielcocenza
Check if applications status are active idle. (#201)
20b8a54 
* Check if applications status are active on wait_for_idle.

- Without status check if the unit is on maintenance it will
  proceed to upgrade or pass the post upgrade step.

Closes: #199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabrielcocenza gabrielcocenza

Labels
bug Something isn't working high
Projects
None yet
Milestone
No milestone
2 participants
@agileshaw @gabrielcocenza