We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This is a follow-up of #1038 (comment)
The current logic will validate the whole bundle beforehand by:
applications
If not it will fail.
A proposal from @DnPlas was to use jsonschema instead for doing the validation which we can investigate.
jsonschema
With some hacky tinkering I managed to create the following schema:
schema = { "type": "object", "required": ["bundle", "name", "docs", "applications"], "properties": { "bundle": {"type": "string"}, "name": {"type": "string"}, "docs": {"type": "string", "format": "uri"}, "applications": { "type": "object", "patternProperties": { "^.*": { "type": "object", "required": ["charm", "channel", "trust", "scale"], "properties": { "charm": {"type": "string"}, "channel": {"type": "string"}, "trust": {"type": "boolean"}, "scale": {"type": "integer"}, "_github_repo_name": {"type": "string"}, "_github_repo_branch": {"type": "string"}, }, "oneOf": [ {"required": ["_github_repo_name", "_github_repo_branch"]}, {"required": ["_github_dependency_repo_name", "_github_dependency_repo_branch"]} ] } } } } }
We have a clear jsonschema for the bundle and decide if we want to switch to this approach
The text was updated successfully, but these errors were encountered:
Thank you for reporting us your feedback!
The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6210.
This message was autogenerated
Sorry, something went wrong.
No branches or pull requests
Context
This is a follow-up of #1038 (comment)
The current logic will validate the whole bundle beforehand by:
applications
in the bundleIf not it will fail.
A proposal from @DnPlas was to use
jsonschema
instead for doing the validation which we can investigate.What needs to get done
With some hacky tinkering I managed to create the following schema:
Definition of Done
We have a clear jsonschema for the bundle and decide if we want to switch to this approach
The text was updated successfully, but these errors were encountered: